Skip to content

Conversation

@nefelim4ag
Copy link
Collaborator

@nefelim4ag nefelim4ag commented Oct 25, 2025

For the LDC1612, the Z offset does not make sense. But we still have the old z_offset save helper.
This introduces the static offset to the Z height map to allow further fine-tuning of calibrated Z values.
Also, I do reload the old helper with the new one to reuse existing infrastructure.

(I can calibrate it against the normal calibrated probe, so there are still homing inconsistencies and thermal drift, but at least I can make Z offset work closer to what is expected.)

Thanks.


Somewhat related to: https://klipper.discourse.group/t/btt-eddy-variance-with-home-command/21827

@Supergun777
Copy link

Good work.

@nefelim4ag nefelim4ag marked this pull request as ready for review October 26, 2025 15:40
@github-actions
Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants